buf icon indicating copy to clipboard operation
buf copied to clipboard

Add an allowlist of which clients can use the LSP server

Open mcy opened this issue 1 year ago • 3 comments

This PR uses the client's reported identity to allowlist which clients we support, with a breakout flag called --break-warranty-seal.

Initially allowlisted are several VSCode variants and nvim, along with comments for where those names came from.

mcy avatar Nov 22 '24 19:11 mcy

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 25, 2024, 6:37 PM

github-actions[bot] avatar Nov 22 '24 19:11 github-actions[bot]

Currently blocked on a decision on the set of clients to include. We intend to merge this but not before we make a decision on this front.

mcy avatar Nov 25 '24 18:11 mcy

I don't think we should touch this PR until we are able to have a convo with the right folks about what we are officially supporting, but when we do come back to this, I think a better name for this flag would be --allow-unsupported-clients.

nicksnyder avatar Nov 25 '24 18:11 nicksnyder

Should we close this now?

bufdev avatar Sep 23 '25 21:09 bufdev

Should we close this now?

I think we should close this, I don't think we're intending on restricting the client.

doriable avatar Sep 23 '25 23:09 doriable