buf icon indicating copy to clipboard operation
buf copied to clipboard

Add buf convert --disallow-unknown

Open bufdev opened this issue 1 year ago • 2 comments

Begins https://github.com/bufbuild/buf/issues/2714. See https://github.com/bufbuild/protoyaml-go/issues/37 for the remaining work for YAML that once fixed, can resolve the aforementioned issue.

bufdev avatar Jun 28 '24 15:06 bufdev

The latest Buf updates on your PR.

NameStatus
build✅ passed
lint✅ passed
format✅ passed
breaking✅ passed

github-actions[bot] avatar Jun 28 '24 15:06 github-actions[bot]

This was just a drive-by PR and it's actually wrong. This adjusts the default behavior for binary and text formats to discard unknown values, which breaks a lot of things in unexpected ways. For some reason, we had discard unknown default to true for JSON, false for wire and txtpb, and implicitly false for yaml. This was likely a decision I made a long time ago.

This PR will need to be significantly adjusted to not introduce breaking changes.

bufdev avatar Jun 28 '24 16:06 bufdev

Closing this for now - this PR is seriously off.

bufdev avatar Aug 01 '24 16:08 bufdev