buefy icon indicating copy to clipboard operation
buefy copied to clipboard

FIX various bugs on Autocomplete component

Open gmercey opened this issue 10 months ago • 1 comments

Fixes

  • https://github.com/buefy/buefy/issues/4098
  • https://github.com/buefy/buefy/issues/4130
  • Autocomplete selection and dropdown logic

Improvements

  • recompute whitelist dynamically
  • update ariaAutocomplete when keepFirst changes
  • adjust scroll listener when appending to body
  • test Autocomplete for 0 values, clearOnSelect, whitelist updates, etc.

gmercey avatar Jun 15 '25 18:06 gmercey

Deploy Preview for buefy-org ready!

Name Link
Latest commit bdbab349fccf34f1a0c6dc9b790ad557ad62cf27
Latest deploy log https://app.netlify.com/projects/buefy-org/deploys/685ad3f3d9be370008044c94
Deploy Preview https://deploy-preview-4139--buefy-org.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 15 '25 18:06 netlify[bot]

This seems to break key navigation with normal async data

dagnelies avatar Jun 17 '25 12:06 dagnelies

This seems to break key navigation with normal async data

how did you get the broken behavior? I tested the component manually and the key navigation works in all cases.

gmercey avatar Jun 18 '25 01:06 gmercey

Here: https://deploy-preview-4139--buefy-org.netlify.app/documentation/autocomplete#async-with-custom-template

I can only navigate the two first elements with the up/down keys... depending on what I type it the search. Sometimes it works, sometimes not, which is really fishy. It looks like long lists are more likely to be buggy. The same happens with both async demos.

dagnelies avatar Jun 18 '25 19:06 dagnelies

looks like the buggy behavior is happening when infinite-scroll is on ?

gmercey avatar Jun 18 '25 19:06 gmercey

Here: https://deploy-preview-4139--buefy-org.netlify.app/documentation/autocomplete#async-with-custom-template

I can only navigate the two first elements with the up/down keys... depending on what I type it the search. Sometimes it works, sometimes not, which is really fishy. It looks like long lists are more likely to be buggy. The same happens with both async demos.

Though one to debug, but here's an update

gmercey avatar Jun 19 '25 04:06 gmercey