buefy icon indicating copy to clipboard operation
buefy copied to clipboard

[Idea / Discussion]: Should we use Sass for some arrow icons

Open service-paradis opened this issue 6 years ago • 3 comments

Description

There is an arrow mixin (using borders) in Bulma that creates a kind of chevron. This is use, for example, in the select component.

IMaybe we could use this kind of mixin for next/previous in some component if no icon props is given. This way, those buttons will display an icon even if there are no icon pack defined. This would be some progress to decouple Buefy from icon pack.

It would not necessarily be a breaking change since the look and feel would be the same.

Why Buefy need this feature

Will prevent mistakes where user does not include icon pack or do not include the needed icons. Will help decoupling Buefy from icon pack.

service-paradis avatar Aug 01 '19 16:08 service-paradis

I guess in this case it should still be configurable, because forcing to have a mandatory arrow icon may be bit non-flexible.

modularcoder avatar Aug 04 '19 10:08 modularcoder

@modularcoder Sure, I think Buefy should continue accepting icon props. But should not use external icons as default icons. This adds non-necessary dependencies in order to use Buefy and leads to many questions/issues.

service-paradis avatar Aug 06 '19 13:08 service-paradis

We could add false as an icon prop to not display any icon for some special cases (eg: css background image)

Tofandel avatar Jun 22 '20 20:06 Tofandel

Closing as stale.

wesdevpro avatar Jan 13 '24 04:01 wesdevpro