Results 117 comments of Budiman Jojo

Ah yeah I missed that `extraManifests` currently is a list of paths without `@` prefix. @mircea-pavel-anton What do you think? My thought is it will be confusing but personally I...

Looking at the code from https://github.com/budimanjojo/talhelper/pull/619, I think the current implementation is already correct? Maybe it's just the wrong wording of the PR? I see the code logic is doing:...

Looks like you're correct. `extraManifests` is broken. It's not working with or without "@" prefixed when called outside of configdir. @jonsch318 you want to work on this? The easiest way...

Please see if the PR I linked above is good enough for this issue. The tests passed (I also added some new tests). There's also something else that I found...

Thank you for the FR! Seems like this is not as easy to implement as it seems, because instead of just `talconfig.yaml`, Talhelper also needs `talsecret.[sops]?.[yml|yaml]` and `talenv.[sops]?.[yml|yaml]` in order...

@nh-mike Because we have `--config-file`, `--env-file`, and `--secret-file` flag for `genconfig` command, so it wouldn't make sense for the environment variable to be different. But those flags are also defaulted...

You're correct. The reasons vary, but here's the brief breakdown on why they're not in the configurations: - `machine.features` is handled by the upstream `generate.WithVersionContract` and it depends on the...

I can add field for `machine.time` if you really need that. And sure I'll add to the docs about this later, probably just suggesting users to use `patches` for missing...

That would be awesome, thank you!

I think this issue is resolved? Or there's something else you want to improve?