buddyboss-platform icon indicating copy to clipboard operation
buddyboss-platform copied to clipboard

Published 20 hours ago • verified publisher icon buddyboss

PROD-885 Fix : #1849 Fixed only show relevant photos

Open ngolwalkar opened this issue 3 years ago • 3 comments

Changes proposed in this Pull Request:

Fixes #1849.

How to test the changes in this Pull Request:

  1. Log in to the user profile.
  2. Go to any joined group.
  3. Create an activity in that group with some photos attached.
  4. Log in to another user profile that is not a connection of the first user.
  5. In the top main menu, go to Pages -> Photos

Proof Screenshots or Video

https://www.loom.com/share/b74d6085dbbb406cbc9a713cadef2bea

ngolwalkar avatar Sep 27 '21 11:09 ngolwalkar

Hi,

Could you please release this fix in the next release ?

Thanks in advance

ExoGeek avatar Jan 31 '22 09:01 ExoGeek

Hello,

If this issue is resolved, may I ask you to release this fix in the next release ? It's very weird that members do see group's photos event if they are not member of that group...

Thanks

ExoGeek avatar Mar 11 '22 16:03 ExoGeek

@chetansatasiya Hello. Do you plan to merge this fix into prod release ? I think it's something important... no ? Thanks for your work !

Ps : I haven't tested the code... I don't know if it really removes "not relevant" photos. Relevant photos are those ones published in : Friend's photos with privacy in ["public", "memberof", "friends"] + photos uploaded by me (on my profile) + photos uploaded in groups I'm member of.

Regards,

ExoGeek avatar May 30 '22 08:05 ExoGeek

Hi @firozwp, do you close this pull request because that "issue" has been resolved in a future release of Buddyboss ?

ExoGeek avatar Nov 21 '22 13:11 ExoGeek

Hello @ExoGeek As discussed with the development team this is working as expected.

firozwp avatar Nov 21 '22 16:11 firozwp

@firozwp Sorry but I think something goes wrong here. There's no reason to see medias from groups you are not a member of. This is absolutely not relevant to user... You do not see those medias on the activity feed (when relevant activity is checked). Why do you see those medias in the screen "photos", "videos" or "documents" ?

Don't you think that something needs to be implemented to only show relevant medias ?

See : #1849

ExoGeek avatar Nov 21 '22 16:11 ExoGeek

@ExoGeek I will ask a developer to share more detail on this. cc: @chetansatasiya

firozwp avatar Nov 21 '22 16:11 firozwp

@ExoGeek Thanks for your feedback on this and I appreciate it. I took a look into this and this is something I can consider a feature request, given code in the PR will not work what you are expecting. We need to make complete scope for all the places like Photos, Videos, and Documents. However, I request you submit a feature request here https://www.buddyboss.com/roadmap/

CC @firozwp @sourabhmatolia @mikejyoung

chetansatasiya avatar Nov 22 '22 06:11 chetansatasiya