buddyboss-platform icon indicating copy to clipboard operation
buddyboss-platform copied to clipboard

PROD-793 Fix/2540 Group messages notification conflict with media uploading components

Open bb-yudhisthir opened this issue 3 years ago • 1 comments

All Submissions:

Changes proposed in this Pull Request:

Fixes #2540.

How to test the changes in this Pull Request:

  1. Deactivate the media uploading component.
  2. Go to any group and sent messages to the group.
  3. Switch back to any member and check the notification.

Proof Screenshots or Video

http://somup.com/crQjfUrOLn http://image.prntscr.com/image/tDYZyLb-SZW96_Mv7LtVfA.png

final: http://somup.com/crQj1frO9M

Other information:

  • [x] Have you added an explanation of what your changes do and why you'd like us to include them?
  • [x] Have you written new tests for your changes, as applicable?
  • [x] Have you successfully run tests with your changes locally?

Changelog entry

Moved & renamed hook function to "bb_messages_save_group_data()" from the Media component folder - bp-media-filters.php file to Message component folder - bp-messages-filters.php file and deprecated the old "bp_media_messages_save_group_data()" in bp-media-filters.php file

bb-yudhisthir avatar Sep 08 '21 07:09 bb-yudhisthir

Thanks for your pull request. It looks like this may be your first contribution to the BuddyBoss Platform open source project. Please note that this project and all contributions to it are public and bounded by the GPL v2.0 license, and that a record of the contribution (including all personal information you submit with it, including your full name and email address) is maintained indefinitely and may be redistributed with this project. If you are not okay with these terms, please close this pull request. Alternatively, you can let us know about your concerns by adding a comment to this pull request.

welcome[bot] avatar Sep 08 '21 07:09 welcome[bot]