tmpNote icon indicating copy to clipboard operation
tmpNote copied to clipboard

Implement undo/redo

Open buddax2 opened this issue 5 years ago • 6 comments

As a user I would like to perform undo/redo action in drawing mode

buddax2 avatar Apr 20 '19 21:04 buddax2

Hi, I could try to implement that :) I'm new here, programmer for a while but new to swift, just looked trough swift.org these days. Not sure what version of swift the app was written in, but I've read Swift 5, so maybe I could also help refactor the code a bit. Is that ok with you? What do you think?

stoiandan avatar Dec 12 '19 17:12 stoiandan

Hmm... I've tried to build the project, but it didn't work, says I need to join a team and add a certificate. New to mac here.. Linux user.

stoiandan avatar Dec 12 '19 18:12 stoiandan

@stoiandan any help will be appreciative. To be able to build you need to select "Sign to Run Locally" and Team None in the project settings. For both targets. Like on the screenshot below: Screenshot 2019-12-13 at 00 02 54

buddax2 avatar Dec 12 '19 22:12 buddax2

Hi,

Thanks for responding, yup that seems to have fix it! I now have only one build problem left. In my version of Xcode (Version 11.3 (11C29)), I cannot import the MASShortcut package:

No such module ‘MASShortcut'

Is it a non standard library? Should I install it?

Thanks

On 13 Dec 2019, at 00:07, Oleksandr Yakubchyk [email protected] wrote:

help will be appreciative. To be able to build you need to select "Sign to Run Locally" and Team None in the project settings. For both targets. Like on the screenshot below:

stoiandan avatar Dec 13 '19 16:12 stoiandan

This is a dependency. So you need to install cocoapods (link) and then run pod install in Terminal in the project directory.

buddax2 avatar Dec 13 '19 16:12 buddax2

It worked, I can build the project now and run it! I just found out on Friday I’ll have an interview soon, probably next week, so I’ll focus on that more this weekend.

And I make the pull requests directly to the main branch? Or should I fork the project and do it that way?

Thanks!

On 13 Dec 2019, at 18:24, Oleksandr Yakubchyk [email protected] wrote:

This is a dependency. So you need to install cocoapods (link https://guides.cocoapods.org/using/getting-started.html) and then run pod install in Terminal in the project directory.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/buddax2/tmpNote/issues/15?email_source=notifications&email_token=ACPIJBDEAEWZJYX7KSHNHDLQYOZKVA5CNFSM4HHKPIQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG2PAVA#issuecomment-565506132, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPIJBH2KEHFE5HEGG3P5T3QYOZKVANCNFSM4HHKPIQA.

stoiandan avatar Dec 14 '19 09:12 stoiandan