bazel-remote icon indicating copy to clipboard operation
bazel-remote copied to clipboard
verified publisher icon buchgr

allow configuring grpc max receive message size

Open jasonwbarnett opened this issue 1 year ago • 3 comments

Fixes https://github.com/buchgr/bazel-remote/issues/658

jasonwbarnett avatar Mar 15 '24 15:03 jasonwbarnett

Seems like Pants is implementing a principled fix in https://github.com/pantsbuild/pants/pull/20708. How do you want to proceeed with this PR @jasonwbarnett ?

buchgr avatar Apr 04 '24 10:04 buchgr

@buchgr It's up to you. I don't know much about gRPC and when it is or isn't appropriate to increase the default message send/receive sizes. If there are cases where it's appropriate, I'd like to see this get merged. If there aren't ever scenarios where this is appropriate, it should probably just be closed without a merge.

jasonwbarnett avatar Apr 05 '24 01:04 jasonwbarnett

I think if we decide to land this PR, then the flag needs to have a prominent warning about ensuring that the client side configuration matches for all clients that use the cache.

However, if pants only needs this for FindMissingBlobs, then that should be an easy fix on the pants side and we should not add this option to bazel-remote.

mostynb avatar Apr 07 '24 16:04 mostynb