bazel-remote icon indicating copy to clipboard operation
bazel-remote copied to clipboard

[metrics] add maximum disk size as metric

Open martijndegouw opened this issue 1 year ago • 3 comments

This allowes for easier monitoring of how much of the assigned space is used.

martijndegouw avatar Oct 11 '23 18:10 martijndegouw

Hi, I'm not sure how useful it is to monitor this value, since you typically set it relative to the filesystem space you have available and then don't need to think about it. What's the use case for adding this?

mostynb avatar Oct 12 '23 20:10 mostynb

Hi, The reason for adding it is that the bazel_remote_disk_cache_logical_bytes metric has no reference now. Monitoring does not know how much head room is left for the bazel-remote cache instance. If a more dynamic value is preferred this metric could be changed to bazel_remote_disk_cache_logical_bytes_free for example.

martijndegouw avatar Oct 13 '23 11:10 martijndegouw

See also https://github.com/buchgr/bazel-remote/pull/696/commits/81961893732633db52e2ed2214229bc21f120dfa from https://github.com/buchgr/bazel-remote/pull/696 that introduces bazel_remote_disk_cache_size_bytes_limit with the labels "evict" and "reject".

ulrfa avatar Oct 13 '23 12:10 ulrfa