dbdpg
dbdpg copied to clipboard
bucardo
Fixed call pg_pid_number
Problem: The code block returning pg_pid_number could never be called.
Fixed bug added to commit 1bfec5fc2532a2f217ceaf0fa188d8bc977b0154 on June 23, 2007
use strict;
use warnings;
use DBD::Pg;
my $dbh = DBI->connect("dbi:Pg:dbname=postgres;host=localhost;port=5432",
"username","",{AutoCommit => 1, RaiseError => 1, PrintError => 0 });
print $dbh->{pg_pid_number}."\n";
$dbh->disconnect();
On the pre-patch version, the result is "Use of uninitialized value in concatenation (.) or string at - line 7."
Returns the PID after applying the patch.
I cannot think of a case when, with careful programming, this call would be necessary, except for debugging, it was not for nothing that this call was in the code with the comment "undocumented". Unless to understand after the fork the connection is open in this process or in parent.
@true-alex : I mean add a test to one of the t/*.t files as part of your pull request. I'm not sure, but I think it should go in t/02attribs.t. Thank you!
On digging into this, it is simply getting the current PID, which is already available to programs via $$ or getpid(), so maybe we don't need to expose this at all? It's only in the code as a convenience for building the name of a prepared statement.
