html-to-image icon indicating copy to clipboard operation
html-to-image copied to clipboard

feat(disable-font-size-shrink): add optional flag to disable font size shrinking

Open Arcainne opened this issue 10 months ago • 4 comments

Description

This adds an optional property to the Option type that can disable the code that shrinks the font size. This resolves #415.

Motivation and Context

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Enhancement (changes that improvement of current feature or performance)
  • [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
  • [ ] Test Case (changes that add missing tests or correct existing tests)
  • [ ] Code style optimization (changes that do not affect the meaning of the code)
  • [x] Docs (changes that only update documentation)
  • [ ] Chore (changes that don't modify src or test files)

Self Check before Merge

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Arcainne avatar Mar 14 '25 00:03 Arcainne

👋 @Arcainne

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

biiibooo[bot] avatar Mar 14 '25 00:03 biiibooo[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.50%. Comparing base (d9b2fcf) to head (1d59779). Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #511   +/-   ##
=======================================
  Coverage   66.50%   66.50%           
=======================================
  Files          10       10           
  Lines         612      612           
  Branches      150      150           
=======================================
  Hits          407      407           
  Misses        144      144           
  Partials       61       61           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 14 '25 00:03 codecov[bot]

Hi @bubkoo , any chance this could be reviewed and merged? This fix preserves backwards compatibility while adding a simple fix for an issue that's been open for a while #415 . Thanks!

Arcainne avatar Mar 21 '25 16:03 Arcainne

Hi @bubkoo, also pushing for the merge of this PR as soon as possible. We're using html-to-image for the generation of pages as images. This is what is created without the option: image

As you can see, a lot of text feels missing from the last line of the text. But if we enable skipping the font resize, we get this image

aka perfection. We would be glad to stop using Arcainne's fork and go back to main branch of the package.

Thanks for all the work!

HVYVince avatar Aug 14 '25 12:08 HVYVince