html-to-image icon indicating copy to clipboard operation
html-to-image copied to clipboard

fix: Abnormal video size

Open daqiude opened this issue 1 year ago • 2 comments

Description

change canvas.drawImage(video) size from clientWidth、clientHeight to videoWidth、videoHeight

Motivation and Context

To fix the problem of image deformation。for example: image

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Enhancement (changes that improvement of current feature or performance)
  • [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
  • [ ] Test Case (changes that add missing tests or correct existing tests)
  • [ ] Code style optimization (changes that do not affect the meaning of the code)
  • [ ] Docs (changes that only update documentation)
  • [ ] Chore (changes that don't modify src or test files)

Self Check before Merge

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

daqiude avatar Jan 23 '24 09:01 daqiude

👋 @daqiude

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

biiibooo[bot] avatar Jan 23 '24 09:01 biiibooo[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b751cbf) 62.93% compared to head (ad7092d) 63.10%. Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   62.93%   63.10%   +0.17%     
==========================================
  Files          10       10              
  Lines         580      580              
  Branches      143      143              
==========================================
+ Hits          365      366       +1     
  Misses        151      151              
+ Partials       64       63       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 23 '24 09:01 codecov[bot]