html-to-image
html-to-image copied to clipboard
fix: workaround for respecting scrollbar positions
Description
Workaround for respecting scrollbar positions
Motivation and Context
Fix #345 and #81. Just setting scrollLeft and scrollTop is not working, therefore this change simulate it by translate all children to the correct position and hide the scrollbars.
Types of changes
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] Enhancement (changes that improvement of current feature or performance)
- [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
- [ ] Test Case (changes that add missing tests or correct existing tests)
- [ ] Code style optimization (changes that do not affect the meaning of the code)
- [ ] Docs (changes that only update documentation)
- [ ] Chore (changes that don't modify src or test files)
Self Check before Merge
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
Codecov Report
Patch coverage: 94.44
% and no project coverage change.
Comparison is base (
b751cbf
) 62.93% compared to head (a6e1355
) 62.93%.
Additional details and impacted files
@@ Coverage Diff @@
## master #408 +/- ##
=======================================
Coverage 62.93% 62.93%
=======================================
Files 10 10
Lines 580 580
Branches 143 143
=======================================
Hits 365 365
Misses 151 151
Partials 64 64
Impacted Files | Coverage Δ | |
---|---|---|
src/clone-node.ts | 71.42% <94.44%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.