html-to-image icon indicating copy to clipboard operation
html-to-image copied to clipboard

fix(mask): add support for -webkit-mask and -webkit-mask-image

Open amiratak88 opened this issue 1 year ago • 5 comments

Description

Add support for mask and mask-image properties for browsers that support them via webkit.

Motivation and Context

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Enhancement (changes that improvement of current feature or performance)
  • [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
  • [ ] Test Case (changes that add missing tests or correct existing tests)
  • [ ] Code style optimization (changes that do not affect the meaning of the code)
  • [ ] Docs (changes that only update documentation)
  • [ ] Chore (changes that don't modify src or test files)

Self Check before Merge

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [x] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

amiratak88 avatar Mar 09 '23 02:03 amiratak88

👋 @amiratak88

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

biiibooo[bot] avatar Mar 09 '23 02:03 biiibooo[bot]

Codecov Report

Patch coverage: 75.00% and no project coverage change

Comparison is base (b751cbf) 62.93% compared to head (569a944) 62.93%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   62.93%   62.93%           
=======================================
  Files          10       10           
  Lines         580      580           
  Branches      143      143           
=======================================
  Hits          365      365           
  Misses        151      151           
  Partials       64       64           
Impacted Files Coverage Δ
src/embed-images.ts 78.04% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Mar 09 '23 02:03 codecov[bot]

What is the status of this PR?

lorenzhh avatar Jul 08 '23 12:07 lorenzhh

Would love to see this get merged! I've run a local fork with these changes, and they work great for me.

gilkeyio avatar May 09 '24 16:05 gilkeyio

Please merge this soon!

matthew-h-wang avatar Aug 20 '24 15:08 matthew-h-wang