html-to-image icon indicating copy to clipboard operation
html-to-image copied to clipboard

fix: include source in npm package

Open jeanfrancois8512 opened this issue 2 years ago • 2 comments

Description

I added "src" in the files attribute of package.json

Motivation and Context

Types of changes

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Enhancement (changes that improvement of current feature or performance)
  • [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
  • [ ] Test Case (changes that add missing tests or correct existing tests)
  • [ ] Code style optimization (changes that do not affect the meaning of the code)
  • [ ] Docs (changes that only update documentation)
  • [ x] Chore (changes that don't modify src or test files)

Self Check before Merge

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

jeanfrancois8512 avatar Sep 20 '22 20:09 jeanfrancois8512

👋 @jeanfrancois8512

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

biiibooo[bot] avatar Sep 20 '22 20:09 biiibooo[bot]

Codecov Report

Base: 67.05% // Head: 67.05% // No change to project coverage :thumbsup:

Coverage data is based on head (009dcac) compared to base (471ad8d). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #316   +/-   ##
=======================================
  Coverage   67.05%   67.05%           
=======================================
  Files          10       10           
  Lines         513      513           
  Branches      119      119           
=======================================
  Hits          344      344           
  Misses        120      120           
  Partials       49       49           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 20 '22 20:09 codecov[bot]

@bubkoo we need this PR plz. by https://github.com/bubkoo/html-to-image/issues/257

Frimko avatar Jan 27 '23 07:01 Frimko

👋 @jeanfrancois8512 Congrats on merging your first pull request! 🎉🎉🎉

biiibooo[bot] avatar Jan 30 '23 05:01 biiibooo[bot]

@bubkoo and new npm-version plz.

Frimko avatar Jan 30 '23 07:01 Frimko

:tada: This PR is included in version 1.11.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

biiibooo[bot] avatar Jan 30 '23 07:01 biiibooo[bot]