html-to-image
html-to-image copied to clipboard
Embed resources for mask CSS property
Description
Only the image in the background property were embedded and the mask property was ignored.
Motivation and Context
Masks are now correctly exported and appear in the resulting image.
Types of changes
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [x] Enhancement (changes that improvement of current feature or performance)
- [ ] Refactoring (changes that neither fixes a bug nor adds a feature)
- [ ] Test Case (changes that add missing tests or correct existing tests)
- [ ] Code style optimization (changes that do not affect the meaning of the code)
- [ ] Docs (changes that only update documentation)
- [ ] Chore (changes that don't modify src or test files)
Self Check before Merge
- [x] My code follows the code style of this project.
- [ ] My change requires a change to the documentation.
- [ ] I have updated the documentation accordingly.
- [x] I have read the CONTRIBUTING document.
- [ ] I have added tests to cover my changes.
- [x] All new and existing tests passed.
👋 @playest
💖 Thanks for opening this pull request! 💖
Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.
Examples of commit messages with semantic prefixes:
fix: don't overwrite prevent_default if default wasn't preventedfeat: add graph.scale() methoddocs: graph.getShortestPath is now available
Things that will help get your PR across the finish line:
- Follow the TypeScript coding style.
- Run
npm run lintlocally to catch formatting errors earlier. - Document any user-facing changes you've made.
- Include tests when adding/changing behavior.
- Include screenshots and animated GIFs whenever possible.
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.
Codecov Report
Base: 67.05% // Head: 63.14% // Decreases project coverage by -3.91% :warning:
Coverage data is based on head (
8f8c62e) compared to base (471ad8d). Patch coverage: 82.45% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
- Coverage 67.05% 63.14% -3.91%
==========================================
Files 10 10
Lines 513 559 +46
Branches 119 131 +12
==========================================
+ Hits 344 353 +9
- Misses 120 147 +27
- Partials 49 59 +10
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/embed-webfonts.ts | 30.63% <0.00%> (-1.81%) |
:arrow_down: |
| src/util.ts | 60.86% <ø> (-2.61%) |
:arrow_down: |
| src/clone-node.ts | 76.36% <85.10%> (+0.24%) |
:arrow_up: |
| src/embed-images.ts | 77.14% <100.00%> (-19.53%) |
:arrow_down: |
| src/clone-pseudos.ts | 29.16% <0.00%> (-50.84%) |
:arrow_down: |
| src/dataurl.ts | 60.00% <0.00%> (-4.45%) |
:arrow_down: |
| src/embed-resources.ts | 82.92% <0.00%> (-2.79%) |
:arrow_down: |
| ... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
👋 @playest Congrats on merging your first pull request! 🎉🎉🎉
:tada: This PR is included in version 1.11.5 :tada:
The release is available on:
Your semantic-release bot :package::rocket: