ngrok icon indicating copy to clipboard operation
ngrok copied to clipboard

Time for deprecation?...

Open neonexus opened this issue 1 year ago • 6 comments

While myself (and I'm sure countless others) appreciate what this package did for us in the past; with Ngrok's new official NPM package (which clocks in less than a MB after secondary installs), I'm left asking the question, is it time to retire / deprecate this package?

It seems like a LOT of work moving forward otherwise.

neonexus avatar Dec 20 '23 04:12 neonexus

The new, official (binary-free) package: @ngrok/ngrok

neonexus avatar Dec 20 '23 04:12 neonexus

It seems like in the official package it is not possible to use the ngrok from command line. So for example not a replacement for us :) yet

node_modules/@ngrok/ngrok/bin/ngrok

scr4bble avatar Jan 04 '24 21:01 scr4bble

It seems like in the official package it is not possible to use the ngrok from command line. So for example not a replacement for us :) yet

node_modules/@ngrok/ngrok/bin/ngrok

@scr4bble Why is running Ngrok from the command line a requirement? The whole point of a package like this is to integrate Ngrok into your Node.js app.

Here's a working example built for Sails.js apps: https://github.com/neonexus/sails-react-bootstrap-webpack/blob/release/ngrok.js

Using that script, I can just run npm run ngrok, and it will boot my application, build assets, and connect Ngrok.

neonexus avatar Jan 05 '24 20:01 neonexus

@scr4bble Why is running Ngrok from the command line a requirement? The whole point of a package like this is to integrate Ngrok into your Node.js app.

Not a requirement for everyone but a feature that some people might need, including us as it allows us to automate a few things and make use of the local web interface amongst others - see https://github.com/ngrok/ngrok-javascript/issues/62

johnrobertcobbold avatar Jan 12 '24 14:01 johnrobertcobbold

Author

You kind of explained it inside your reply. The file you linked to is exactly the thing we don't need when being able to just run the "binary".

Our yarn ngrok command runs a simple two liner shell script (and even this shell script is not necessary if you don't mind slightly longer command inside package.json):

source "${SCRIPT_DIR}/../.env"
../node_modules/ngrok/bin/ngrok http --inspect=false ${PORT}

That feels much easier than being forced to write the javascript/typescript code to integrate ngrok into the app.

scr4bble avatar Jan 16 '24 12:01 scr4bble

It seems like in the official package it is not possible to use the ngrok from command line. So for example not a replacement for us :) yet node_modules/@ngrok/ngrok/bin/ngrok

@scr4bble Why is running Ngrok from the command line a requirement? The whole point of a package like this is to integrate Ngrok into your Node.js app.

Here's a working example built for Sails.js apps: https://github.com/neonexus/sails-react-bootstrap-webpack/blob/release/ngrok.js

Using that script, I can just run npm run ngrok, and it will boot my application, build assets, and connect Ngrok.

how about just stfu if you don't use the command line

bentacos avatar Mar 31 '24 19:03 bentacos