ngrok icon indicating copy to clipboard operation
ngrok copied to clipboard

Set correct binary for darwin-arm architecture

Open Esmilis opened this issue 3 years ago • 7 comments

Currently it crashes while running post install script with "ngrok - platform darwinarm64 is not supported." This picks the correct binary for darwin arm platform

Esmilis avatar May 05 '21 02:05 Esmilis

Ok, i now realise the crash is because i'm still on version 3. However, ngrok does provide specific binaries for arm. Might still be worth updating?

Esmilis avatar May 05 '21 02:05 Esmilis

Thanks for this! We made an update to add the amd download that seemed to support arm, but now there is a specific distribution for arm, it is likely best to update.

I don't have an M1 laptop, so can't test this myself. If you are happy to guarantee this works for you, then I will merge.

philnash avatar May 07 '21 05:05 philnash

I can confirm that this works on my M1. I opened a PR without looking here first. Apologies.

clakeb avatar Feb 11 '22 17:02 clakeb

FWIW, I just tried the change from this PR and can also say that it works.

tobias-theobald avatar Apr 08 '22 15:04 tobias-theobald

I accidentally opened a PR for this same issue and can confirm the fix in this one does indeed work.

rhyek avatar May 06 '22 16:05 rhyek

Just noticed how old this PR is. Why has this not been merged?

rhyek avatar May 06 '22 16:05 rhyek

If anyone needs a quick fix you can use this as a dependency in your package.json: "ngrok": "github:rhyek/ngrok#9977bd88a0ef8e20ee7d83ae563fdb4deb8920d6". It will install ngrok from this branch: https://github.com/rhyek/ngrok/tree/fix/darwin-arm64-correct-binary

rhyek avatar May 06 '22 16:05 rhyek