bubbleboy14

Results 53 comments of bubbleboy14

Hey @martydingo. > adding the parameter `dispatcher=rel` does seem to work at first, however specifying this parameter causes no output but no loop, I see a clean exit of the...

@j-linds @cyr123 @martydingo @QuinnDamerell @rm-you @garethsb try this PR: https://github.com/websocket-client/websocket-client/pull/875 Does it fix things for you guys? Thoughts @engn33r ?

Good call @rm-you, I added a lower() to the PR. When I pass a url without a (ws or wss) protocol, I get "hostname is invalid - goodbye". Fairly sure...

@maynardflies you're right, this is probably inconsistent with the docs. IIRC, the reconnect kwarg was introduced (initially with a default of 5) with version 1.4.0. But then, if I'm not...

Yes, we should update the docs. IIRC, there may be some cases in which passing a dispatcher results in a slightly more stable (better at surviving spotty network conditions) connection....

Hello @adamwojt . Could you please provide a minimal test case (client and server if possible) that reproduces the issue?

Awesome, thanx for the repro! Try this branch/pr @adamwojt: https://github.com/websocket-client/websocket-client/pull/859 So WebSocketApp._send_ping() contains a while loop run in a thread. It looks like there is/was (on line 254) a "break"...

Did anyone test https://github.com/websocket-client/websocket-client/pull/859 ? As I recall, the "ping/pong timed out" in the traceback (provided by OP) was happening because the code stopped sending pings after the first reconnect...

> * The ping Thread will continue to send pings after the websocket connection ist lost. This will result in further errors and reconnects. Hm, interesting. I haven't observed this,...

@milosivanovic the main alternative is to run without an async dispatcher, which is the default. If you want an alternative async dispatcher, pyevent has the same API, but I'm not...