Villain icon indicating copy to clipboard operation
Villain copied to clipboard

Shortcut keys

Open btzr-io opened this issue 4 years ago • 12 comments

Add shortcut keys to control the viewer like f to toggle fullscreen.

btzr-io avatar Oct 15 '19 05:10 btzr-io

I think needs a simple system to register them, unless openseadragon provides something for this,.

btzr-io avatar Oct 15 '19 05:10 btzr-io

I'll have a swing at it

Nargonath avatar Oct 15 '19 09:10 Nargonath

Awesome, thanks. Let me know if you have any questions.

btzr-io avatar Oct 15 '19 15:10 btzr-io

Alright, thanks.

Nargonath avatar Oct 15 '19 15:10 Nargonath

@Nargonath are you still working on this ?

btzr-io avatar Oct 17 '19 16:10 btzr-io

Yes I am. I just had some other stuff to take care in other open source projects I maintain. 😃 I wrote some code, now I just need to test it. I should be able to do it during the weekend.

Nargonath avatar Oct 18 '19 07:10 Nargonath

@Nargonath Oh lol, dont worry just checking

btzr-io avatar Oct 18 '19 07:10 btzr-io

No worries. I might ask you some questions about testing using the examples if I cannot figure it out myself.

Nargonath avatar Oct 18 '19 08:10 Nargonath

Isn't this issue closed by the PR mentioned above?

Nargonath avatar Oct 22 '19 12:10 Nargonath

@Nargonath No, needs improvements and more shortcut keys

btzr-io avatar Oct 22 '19 16:10 btzr-io

I see. I deleted the work I did because it was covered by the above MR.

Nargonath avatar Oct 23 '19 07:10 Nargonath

Openseadragon Shortcut keys: https://github.com/openseadragon/openseadragon/blob/92904b7ac9f46583a3ba9237446c0608a0eb2ca0/src/viewer.js#L2583

btzr-io avatar Aug 07 '22 06:08 btzr-io