bttv icon indicating copy to clipboard operation
bttv copied to clipboard

Fix Split chat not working on Livestreams

Open Zerwin opened this issue 1 year ago • 2 comments

Fixes #673

Changes

Twitch changed chat messages in Live Streams to be LinearLayouts with the chat_message_item as a child. This fixes it to target the child rather than the LinearLayout to make Split Chat work again.

Checklist

  • [x] My change builds
  • [x] I tested my change
  • [ ] ~~I use the "bttv_" prefix for all resources I propose~~
  • [ ] ~~When adding a string I also added it to the bttv.Res.strings Enum and res/values/strings.xml (in mod) and res/values/public.xml (in disass)~~
  • [ ] ~~If my change is significant enough, I added it to the CHANGELOG.md under master~~
  • [ ] ~~I'll add myself and everyone else who contributed to this change to the contributors list using all-contributors~~
  • [x] I license my changes according to the MIT License.

Zerwin avatar Aug 30 '24 11:08 Zerwin

This only highlights the text, not the whole "row"

image

FoseFx avatar Aug 30 '24 11:08 FoseFx

The LinearLayout only stretches as far as the text, not the row. I thought of trying to set the width to the whole space, but that might introduce other bugs that could be a headache to deal with.

Zerwin avatar Aug 30 '24 12:08 Zerwin

I made it so that comments are as wide as the parent element now. This should make the entire "row" colored. I tested it for a bit and at least couldn't immediately find any bugs because of this change.

Zerwin avatar Dec 23 '24 22:12 Zerwin

This should be all of the changes

Zerwin avatar Dec 27 '24 02:12 Zerwin