bttv icon indicating copy to clipboard operation
bttv copied to clipboard

Update dependencies and tools to target API 33

Open Zerwin opened this issue 1 year ago • 2 comments

Changes

Updates the dependencies, Gradle and build tools. Several linting warnings and errors are also fixed.

Checklist

  • [x] My change builds
  • [x] I tested my change
  • [ ] ~~I use the "bttv_" prefix for all resources I propose~~
  • [ ] ~~When adding a string I also added it to the bttv.Res.strings Enum and res/values/strings.xml (in mod) and res/values/public.xml (in disass)~~
  • [ ] ~~If my change is significant enough, I added it to the CHANGELOG.md under master~~
  • [ ] ~~I'll add myself and everyone else who contributed to this change to the contributors list using all-contributors~~
  • [x] I license my changes according to the MIT License.

I did not run ubi, because the build tools 33 use d8 instead of dx now but ubi itself seems to have dx hardcoded in some places.

Zerwin avatar Aug 25 '24 14:08 Zerwin

Seems like the build failed because the KSPASS variable was missing in the CI pipeline. Not really sure why though.

Zerwin avatar Aug 25 '24 14:08 Zerwin

I'd like to delay merging this until we have rebased to a more recent version, as these changes might cause tricky to debug issues, for which one reason may be an outdated base.

Sounds good to me, as it mostly touches files that aren't usually changed in rebases it shouldn't be a problem to do this later.

Zerwin avatar Aug 26 '24 15:08 Zerwin