Brandon Trautmann

I just did a test against that commit and here's what I saw: ### BEFORE **Test 1** ```console flutter: \^[[38;5;208m[W]\^[[0m Slow query (670ms)! SELECT "db_transactions"."uuid" AS "db_transac flutter: \^[[38;5;208m[W]\^[[0m Slow...

Do you think the remaining slowness is due to the issue you mentioned above? > At the moment, a source of inefficiency is that every insert creates its own SQL....

> Sorry to keep nagging you with the profiler, but is any change visible there? Here's what I'm seeing now: **BaseExecuter.runRequest** **BaseExecuter.runRequest** (again) **DriftCommunication.send** **JoinedSelectStatement.mapRow** **InsertStatement.createContext** > I suggest taking...

 Here are timings after moving the heaviest insertion procedure to a batch (`insertTransactions` inserts ~9k entities, the rest are only inserting ~1-50 entities and...

> I look into your reproduce_repo. I see you use [`go`](https://pub.dev/documentation/go_router/latest/go_router/GoRouter/go.html) instead [`push`](https://pub.dev/documentation/go_router/latest/go_router/GoRouter/push.html), I wonder why you use this method. Our team uses `go` pretty much everywhere because it's idempotent...

> For the second row as I referenced above, running the reproduction sample and testing with `canPop` set to false, I can't seem to reproduce `onPopInvoked(appBar)` being true (logs below)....

As requested, I've opened https://github.com/flutter/flutter/issues/138737 which covers all GoRouter cases. I've narrowed the scope of this ticket as well as its description to capture the issue with Navigator 1.0 APIs.

> @justinmc should have a final say about this but this is WAI as far as I know, since nothing should stop cupertino back gesture. Otherwise; it would be considered...

@mym0404 my (completely uneducated) guess (without looking at the code for the back gesture) is that they have the same root cause. I.e I'm assuming the back gesture ends up...

> The issue titled "PopScope does not invoke onPopInvoked for iOS back gesture when canPop set to false" is misleading. This is because when canPop is set to false, the...