gnag icon indicating copy to clipboard operation
gnag copied to clipboard

Gnag comments with incorrect PR SHA if 1+ new commits were added between build starting and Gnag reporting

Open stkent opened this issue 8 years ago • 0 comments

screen shot 2016-07-05 at 10 36 15 am

Expected: comments reported as applying to SHAs 3623c3b then 005ef31. Actual: comments reported as applying to SHA 005ef31 both times.

An improved solution would be to pull the PR HEAD SHA ASAP in the Gnag build. May also be possible to capture a CI env var with this information (which would be much more robust). Maybe we add a new entry in the Gnag configuration block to allow this?

stkent avatar Jul 05 '16 14:07 stkent