fulltext icon indicating copy to clipboard operation
fulltext copied to clipboard

Include MessageExtractor code in fulltext

Open giampaolo opened this issue 7 years ago • 4 comments

MsgExtractor lib is not easy to deal with in terms of packaging and as a dependency in general, see:

https://github.com/mattgwwalker/msg-extractor/issues/23
https://github.com/mattgwwalker/msg-extractor/issues/24
https://github.com/mattgwwalker/msg-extractor/issues/25

I even disabled travis CI for python 2.7 because it could not get installed: https://github.com/btimby/fulltext/pull/85/commits/2b01185f79ae3662b8e00ba928bb4f70cd3cb636

With this PR I just include it in fulltext code base. This will make builds faster as it's one less dep to retrieve from GIT (there's no MsgExtractor on PYPI).

giampaolo avatar Jan 18 '18 11:01 giampaolo

Why not just fork and add to PyPI?

btimby avatar Jan 18 '18 14:01 btimby

I'm not the owner so I cannot register MsgExtractor on PYPI. I filed a couple of issues on MsgExtractor bug tracker asking if they're interested in packaging it properly and put it on PYPI (they are). I made an initial PR but it's not reviewed/merged yet. Basically we can't properly fix this until they push it forward.

giampaolo avatar Jan 18 '18 14:01 giampaolo

See: https://github.com/mattgwwalker/msg-extractor/pull/26/files https://github.com/mattgwwalker/msg-extractor/issues/23 https://github.com/mattgwwalker/msg-extractor/issues/25

giampaolo avatar Jan 18 '18 14:01 giampaolo

Have your issues been fixed in the most recent version of msg-extractor?