nativescript-imagecropper icon indicating copy to clipboard operation
nativescript-imagecropper copied to clipboard

Not working on Android API 29 With Nativescript 6.1.1

Open jitendraashutec opened this issue 5 years ago • 4 comments

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital letter.

Which platform(s) does your issue occur on?

  • Android
  • Android versions - API 29
  • both. emulator and device.

Please, provide the following version numbers that your issue occurs with:

  • CLI: 6.1.2
  • Runtime(s): 6.1.2
  • Plugin(s): nativescript-imagecropper": "1.0.5"

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.

I have upgraded nativescript 6.1.2. After that it is not working in Android API 28 and 29.

jitendraashutec avatar Oct 04 '19 13:10 jitendraashutec

I'm using this cropper on devices running API 28 with no issues, haven't tried it on 29

shiv19 avatar Oct 06 '19 20:10 shiv19

@shiv19 I have checked in API 28 and it is working. but in API 29 I am getting error:

Error: Cannot convert object to Ljava/lang/Throwable; at index 0 JS: Error: Cannot convert object to Ljava/lang/Throwable; at index 0

I think API 29 uses Android X and to support I think you should update https://github.com/Yalantis/uCrop dependancy.

jitendraashutec avatar Oct 07 '19 10:10 jitendraashutec

The version of this plugin at npm.proplugins.org already uses the updated Android X lib. But for this public version, I welcome any incoming PRs (after I reveiw it)

shiv19 avatar Oct 07 '19 10:10 shiv19

please review the Pull Request, I have fixed Android X crashing issue. https://github.com/bthurlow/nativescript-imagecropper/pull/61

jitendraashutec avatar Oct 09 '19 09:10 jitendraashutec