bthirion
"Confound_prediction is a Python module to control confound effect in the prediction or classification model." -> "Confound_prediction is a Python module to control confound effect in prediction or classification models."...
Here are some issues I have encountered using nistats reports. * Does not seem to take into account use-provided parameters for thresholding * the contrast maps only have the positive...
### Is there an existing issue for this? - [X] I have searched the existing issues ### Describe your proposed suggestion in detail. The decoding maps proposed at the end...
This PR is a massive code simplification. We should decide whether we want it or not.
### Is there an existing issue for this? - [X] I have searched the existing issues ### Operating system - [X] Linux - [ ] Mac - [ ] Windows...
I agree, this concatenation of parameters is difficult to understand. It is somewhat consistent across solvers, but I think we should flatten these variables. Once again, I think this would...
I agree, most functions in `solvers/utils.py` are not meant to be public (because they are called through `fugw.mappings` instances, which themselves call `fugw.solvers` instances). I added a docstring, and suggest...
Indeed, these functions are not tested yet. Would be an important addition to make in a follow-up PR. _Originally posted by @alexisthual in https://github.com/alexisthual/fugw/pull/29#discussion_r1228193498_