bitcoinz icon indicating copy to clipboard operation
bitcoinz copied to clipboard

Implement sapling viewing keys | 2.0.8-rc1

Open MarcelusCH opened this issue 2 years ago • 2 comments

As our discussion on Discord, we go now forward with sapling viewing keys .

References:

  • https://github.com/zcash/zcash/issues/3060
  • https://github.com/zcash/zcash/pull/3822

I think that this are the needed dependencies for doing it (by this initial PR). The different updates have been committed with same PR name as zcash core node.

I will commit the bellow updates as well into the BtcZ node v2.0.8-rc1 (or should this may be a beta?):

  • https://github.com/zcash/zcash/pull/4362/commits
  • https://github.com/zcash/zcash/pull/4370/commits

Change log up to this PR open

add z_gettreestate RPC Fix the use of 0 as expiryheight in createrawtransaction, to disable expiry Bitcoin 0.12 wallet PRs 1 Fix CVE-2017-18350 Wallet interface refactor Update z_viewtransaction insightexplorer: LOCK(cs_main) during rpcs Return address and type of imported key in z_importkey

MarcelusCH avatar Jul 03 '22 11:07 MarcelusCH

Ok, there are some more update to pull in before to be able to merge successfully the import/export/init usage of full viewing key. Here is the backward compatibility list of what we need some of (not all). https://github.com/zcash/zcash/pulls?page=38&q=is%3Apr+is%3Aclosed But I stuck one witch one is depending each other. (We not schould add every update)

MarcelusCH avatar Jul 05 '22 21:07 MarcelusCH

Added also the followings update in the last commit :

This commit allows now the binaries to be compiled (on ubuntu 20.04) and to use the z_importviewingkey, z_exportviewingkey, and also to able to see the shilded tx with only the viewing key (instead the std spending key) with the z_viewtransaction function.

MarcelusCH avatar Jul 24 '22 06:07 MarcelusCH

Updated deprecation to blk 1208650 (AUG 2023) and renamed as stable version.

MarcelusCH avatar Sep 03 '22 11:09 MarcelusCH

this was merged in https://github.com/btcz/bitcoinz/pull/70

cryptorex avatar Sep 09 '22 20:09 cryptorex