btcd icon indicating copy to clipboard operation
btcd copied to clipboard

[feature]: When tagging v0.25, please bump version for all self-dependencies in all go.mod files

Open litecomb opened this issue 7 months ago • 4 comments

Dear author. If you are not willing to provide one go.mod file in the root of the project, then do this before tagging the next release.

  1. Bump all self-dependencies to v0.25 in all go.mod files
  2. Tag v0.25

Thank you

litecomb avatar Jun 14 '25 19:06 litecomb

Fixes: #2127

litecomb avatar Jun 14 '25 19:06 litecomb

https://github.com/btcsuite/btcd/pull/1825 is ready for your review, thank you.

guggero avatar Jun 16 '25 06:06 guggero

My original plan is bad, you should consider double version bump:

  1. Tag 0.24.99
  2. Bump self dependencies, possibly go mod tidy
  3. Tag 0.25.0 right after without any coding changes.

litecomb avatar Sep 29 '25 20:09 litecomb

To illustrate the 0.24.99 idea, (the replace directives won't be included, only for testing):


---
 btcec/go.mod        |  4 +++-
 btcutil/go.mod      |  8 +++++---
 btcutil/psbt/go.mod | 16 ++++++++++++----
 go.mod              | 16 ++++++++++++----
 v2transport/go.mod  |  8 ++++++--
 5 files changed, 38 insertions(+), 14 deletions(-)

diff --git a/btcec/go.mod b/btcec/go.mod
index 95e86db..6ee7de4 100644
--- a/btcec/go.mod
+++ b/btcec/go.mod
@@ -2,8 +2,10 @@ module github.com/btcsuite/btcd/btcec/v2
 
 go 1.22
 
+replace github.com/btcsuite/btcd/chaincfg/chainhash => ../chaincfg/chainhash
+
 require (
-	github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1
+	github.com/btcsuite/btcd/chaincfg/chainhash v1.25.0
 	github.com/davecgh/go-spew v1.1.1
 	github.com/decred/dcrd/dcrec/secp256k1/v4 v4.0.1
 	github.com/stretchr/testify v1.8.0
diff --git a/btcutil/go.mod b/btcutil/go.mod
index b0b8597..c7f9ffa 100644
--- a/btcutil/go.mod
+++ b/btcutil/go.mod
@@ -2,11 +2,13 @@ module github.com/btcsuite/btcd/btcutil
 
 go 1.22
 
+replace github.com/btcsuite/btcd => ../
+
 require (
 	github.com/aead/siphash v1.0.1
-	github.com/btcsuite/btcd v0.24.2
-	github.com/btcsuite/btcd/btcec/v2 v2.1.3
-	github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0
+	github.com/btcsuite/btcd v0.24.99
+	github.com/btcsuite/btcd/btcec/v2 v2.25.0
+	github.com/btcsuite/btcd/chaincfg/chainhash v1.25.0
 	github.com/davecgh/go-spew v1.1.1
 	github.com/decred/dcrd/dcrec/secp256k1/v4 v4.0.1
 	github.com/kkdai/bstream v0.0.0-20161212061736-f391b8402d23
diff --git a/btcutil/psbt/go.mod b/btcutil/psbt/go.mod
index 09f4c3f..6a475e2 100644
--- a/btcutil/psbt/go.mod
+++ b/btcutil/psbt/go.mod
@@ -2,11 +2,19 @@ module github.com/btcsuite/btcd/btcutil/psbt
 
 go 1.22
 
+replace github.com/btcsuite/btcd => ../../
+
+replace github.com/btcsuite/btcd/btcec/v2 => ../../btcec
+
+replace github.com/btcsuite/btcd/btcutil => ../../btcutil
+
+replace github.com/btcsuite/btcd/chaincfg/chainhash => ../../chaincfg/chainhash
+
 require (
-	github.com/btcsuite/btcd v0.24.2
-	github.com/btcsuite/btcd/btcec/v2 v2.3.4
-	github.com/btcsuite/btcd/btcutil v1.1.5
-	github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0
+	github.com/btcsuite/btcd v0.24.99
+	github.com/btcsuite/btcd/btcec/v2 v2.25.0
+	github.com/btcsuite/btcd/btcutil v1.25.0
+	github.com/btcsuite/btcd/chaincfg/chainhash v1.25.0
 	github.com/davecgh/go-spew v1.1.1
 	github.com/stretchr/testify v1.8.4
 )
diff --git a/go.mod b/go.mod
index 2d543d8..057f3f9 100644
--- a/go.mod
+++ b/go.mod
@@ -1,10 +1,18 @@
 module github.com/btcsuite/btcd
 
+replace github.com/btcsuite/btcd/btcec/v2 => ./btcec/
+
+replace github.com/btcsuite/btcd/btcutil => ./btcutil/
+
+replace github.com/btcsuite/btcd/chaincfg/chainhash => ./chaincfg/chainhash/
+
+replace github.com/btcsuite/btcd/v2transport => ./v2transport/
+
 require (
-	github.com/btcsuite/btcd/btcec/v2 v2.3.5
-	github.com/btcsuite/btcd/btcutil v1.1.5
-	github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0
-	github.com/btcsuite/btcd/v2transport v1.0.1
+	github.com/btcsuite/btcd/btcec/v2 v2.25.0
+	github.com/btcsuite/btcd/btcutil v1.25.0
+	github.com/btcsuite/btcd/chaincfg/chainhash v1.25.0
+	github.com/btcsuite/btcd/v2transport v1.25.0
 	github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f
 	github.com/btcsuite/go-socks v0.0.0-20170105172521-4720035b7bfd
 	github.com/btcsuite/websocket v0.0.0-20150119174127-31079b680792
diff --git a/v2transport/go.mod b/v2transport/go.mod
index 104d597..e824b66 100644
--- a/v2transport/go.mod
+++ b/v2transport/go.mod
@@ -2,14 +2,18 @@ module github.com/btcsuite/btcd/v2transport
 
 go 1.23.2
 
+replace github.com/btcsuite/btcd/btcec/v2 => ../btcec/
+
+replace github.com/btcsuite/btcd/chaincfg/chainhash => ../chaincfg/chainhash/
+
 require (
-	github.com/btcsuite/btcd/btcec/v2 v2.3.5
+	github.com/btcsuite/btcd/btcec/v2 v2.25.0
 	github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f
 	golang.org/x/crypto v0.25.0
 )
 
 require (
-	github.com/btcsuite/btcd/chaincfg/chainhash v1.1.0 // indirect
+	github.com/btcsuite/btcd/chaincfg/chainhash v1.25.0 // indirect
 	github.com/decred/dcrd/dcrec/secp256k1/v4 v4.0.1 // indirect
 	golang.org/x/sys v0.22.0 // indirect
 )
-- 
2.48.1

litecomb avatar Sep 29 '25 20:09 litecomb