btcd icon indicating copy to clipboard operation
btcd copied to clipboard

[rebase of #845] rpc: add new btcd extension commands: addminingaddr, delminingaddr, listminingaddrs

Open yashbhutwala opened this issue 5 years ago • 7 comments

This is a rebase of #845 on master, closes #1411 😃

yashbhutwala avatar Jun 26 '19 01:06 yashbhutwala

Would love to have this functionality to test apps w/ btcd (neutrino). @Roasbeef

dannypaz avatar Jul 21 '19 03:07 dannypaz

FYI was seeing a null pointer reference when running this code in test. s.server returns null. The fix is to add a second arg s server to newRpcServer to set the server property for those methods.

dannypaz avatar Jul 21 '19 21:07 dannypaz

@jcvernaleo (as per #1530)

  • Low priority
  • Enhancement

jakesylvestre avatar Mar 04 '20 13:03 jakesylvestre

What needs to be done for this to be merged?

dannypaz avatar Mar 05 '20 20:03 dannypaz

@dannypaz if you could rebase and squash it that would definitely help on my end. I know you rebased this a long time ago but since I'm trying to finally get some of these old PRs in there is going to be some churn. This one is pretty well reviewed already so it is high on my list.

jcvernaleo avatar Mar 05 '20 21:03 jcvernaleo

Will take another quick pass at reviewing in the mean time once rebased

jakesylvestre avatar Mar 05 '20 21:03 jakesylvestre

@yashbhutwala we're going to have to rebase against master to fix these conflicts and get these tests to stop running on travis

jakesylvestre avatar Aug 31 '20 19:08 jakesylvestre