btcd
btcd copied to clipboard
[rebase of #845] rpc: add new btcd extension commands: addminingaddr, delminingaddr, listminingaddrs
This is a rebase of #845 on master, closes #1411 😃
Would love to have this functionality to test apps w/ btcd (neutrino). @Roasbeef
FYI was seeing a null pointer reference
when running this code in test. s.server
returns null. The fix is to add a second arg s server
to newRpcServer
to set the server
property for those methods.
@jcvernaleo (as per #1530)
- Low priority
- Enhancement
What needs to be done for this to be merged?
@dannypaz if you could rebase and squash it that would definitely help on my end. I know you rebased this a long time ago but since I'm trying to finally get some of these old PRs in there is going to be some churn. This one is pretty well reviewed already so it is high on my list.
Will take another quick pass at reviewing in the mean time once rebased
@yashbhutwala we're going to have to rebase against master to fix these conflicts and get these tests to stop running on travis