btcd icon indicating copy to clipboard operation
btcd copied to clipboard

Published 20 hours ago • verified publisher icon btcsuite

Switch AllowHighFee to MaxFeeRate

Open vctt94 opened this issue 5 years ago • 5 comments

After commit https://github.com/bitcoin/bitcoin/commit/c033c4b5cef89a654e4d9d5c5f9bd823871b068b bitcoin switched allowHighFee to maxFeeRate on sendrawtransaction rpc command.

This PR switches AllowHighFees to MaxFeeRate as well.

vctt94 avatar Apr 10 '19 12:04 vctt94

Seems we also need to update the btcd server as well. Otherwise, we won't be able to respond to this new request.

Roasbeef avatar Apr 17 '19 03:04 Roasbeef

Thanks for reviewing.

I updated as requested.

vctt94 avatar Apr 17 '19 21:04 vctt94

Thanks for pointing that Roasbeef. I moved the maxFeeRate to the ProcessTransaction method. Believe this looks better and there is no need of txindex, anymore.

Also fixed the others comments

vctt94 avatar Apr 24 '19 19:04 vctt94

@jcvernaleo (as per #1530)

  • Low priority
  • Bug (because RPC is outdated)
  • Outdated

jakesylvestre avatar Mar 04 '20 13:03 jakesylvestre

@vctt94 Can you please rebase this PR on latest master? Let's try to have dual compatibility, following the fixes to the sendrawtransaction command done in #1659.

onyb avatar Nov 16 '20 13:11 onyb