btcpayserver icon indicating copy to clipboard operation
btcpayserver copied to clipboard

Delete & Disable users should be displayed in an overlay modal

Open dstrukt opened this issue 1 year ago • 2 comments

Server Settings > Users

Current

Screen Shot 2024-01-22 at 6 09 19 PM Screen Shot 2024-01-22 at 6 04 57 PM Screen Shot 2024-01-22 at 6 05 14 PM

Proposed

All of these states should be displayed in our standard overlay modal, not the opaque background in the current view.

dstrukt avatar Jan 23 '24 02:01 dstrukt

We omitted this, because there are some more checks involved on the backend, like verifying this is not the last admin. I can take another look, but it was a concious decision to have it like this, not an oversight.

dennisreimann avatar Jan 23 '24 07:01 dennisreimann

Ahh apologies if it was conscious decision, enough time has passed for me to forget!

If it's not feasible, feel free to close.

dstrukt avatar Jan 23 '24 17:01 dstrukt

@dennisreimann so we should close it because it's not feasible?

pavlenex avatar Mar 14 '24 08:03 pavlenex

Yes, let's keep it as it is.

dennisreimann avatar Mar 14 '24 10:03 dennisreimann