btcpayserver icon indicating copy to clipboard operation
btcpayserver copied to clipboard

[Bug]: No error msg if no wallet is connected checkout V2

Open Bas02 opened this issue 2 years ago • 5 comments

What is your BTCPay version?

1.7.3

How did you deploy BTCPay Server?

lunanode

What happened?

Deployed new instance, new store, made a POS without yet connecting (creating) a wallet for the store. Whenever you now generate invoice (say through a connected shopify) it doesn't pop up the error msg of a missing wallet.

Low chances of this happening, however, old checkout did give error msg.

How did you encounter this bug?

Create store. Create POS Create connection to shopify DONT connect/create a wallet yet.

Create invoice and no QR shows nor does it error on not having a wallet connected.

Relevant log output

No response

What browser do you use?

No response

Additional information

SATSBACKBUG

Are you sure this is a bug report?

  • [X] I confirm this is a bug report

Bas02 avatar Jan 10 '23 14:01 Bas02

How were you able to create an app before creating a wallet, and then how were you able to generate an invoice without even having a wallet, my understanding is that these actions shouldn't be possible, or am I misunderstanding your bug report @Bangalisch ?

pavlenex avatar Jan 11 '23 09:01 pavlenex

These actions are fully possible.

Bas02 avatar Jan 11 '23 14:01 Bas02

I think the "Create connection to shopify"/using an external system to generate invoices is the point here. I could not reproduce it with our internal apps or the raw invoice creation: Those guide you towards setting up at least one payment method first.

dennisreimann avatar Jan 12 '23 15:01 dennisreimann

Yeah, that's what I was thinking, @Bangalisch can you either provide more info or exact steps, because it's not making much sense.

pavlenex avatar Jan 13 '23 11:01 pavlenex

I couldn't repro. I created a new store with no wallet and set up a Shopify integration and I get an error when I try to check out. This happens both with the new and the old versions of the checkout page. As soon as I create a wallet the error goes away.

Capture

I followed this guide https://docs.btcpayserver.org/Shopify/

bolatovumar avatar Feb 17 '23 04:02 bolatovumar