btcpayserver-docker icon indicating copy to clipboard operation
btcpayserver-docker copied to clipboard

Added "project-name" param so containers have better names

Open woutersamaey opened this issue 3 years ago • 2 comments

Containers won't have the generated_ prefix anymore, but btcpayserver_ instead. The generated_ prefix comes from the dir name Generated where the docker-compose.yml is at and this is default behaviour.

WARNING: This can be tricky and maybe even dangerous if best practices were not followed. Let's discuss.

This change helps to find containers that are part of the BTCPay Server on a server that's running other apps as well.

All I did was add -p btcpayserver to all docker-compose commands.

woutersamaey avatar Nov 03 '21 10:11 woutersamaey

I think this would be a breaking change for some scripts.

Kukks avatar Jun 06 '22 11:06 Kukks

Yes, while I agree this should have been done from day 1, I am against changing it now as it will breaks quite a lot of things. (documentations and scripts)

NicolasDorier avatar Jun 07 '22 09:06 NicolasDorier