BTCPayServer.Lightning icon indicating copy to clipboard operation
BTCPayServer.Lightning copied to clipboard

Published 20 hours ago • verified publisher icon btcpayserver

Fixes key locking issues

Open MarkCiliaVincenti opened this issue 1 year ago • 4 comments

Fixes race condition mentioned in #148 and also a potential issue when token is cancelled not releasing semaphore during await Task.Delay(2500, _cts.Token); possibly causing issues.

MarkCiliaVincenti avatar Jan 20 '24 08:01 MarkCiliaVincenti

Fixed, @Kukks @NicolasDorier!

MarkCiliaVincenti avatar Jan 30 '24 19:01 MarkCiliaVincenti

@MarkCiliaVincenti hey, I prefer we don't get a third party dependency for this, can you just copy the relevant classes.

NicolasDorier avatar Feb 02 '24 10:02 NicolasDorier

I would need to copy most classes in here, and then what, update this project whenever I update my library? I don't understand what benefit you believe you will get from using 3rd party classes as opposed to a 3rd party dll. If the reason is security, you can step into and debug the code in the NuGet package as I enabled that functionality, which allows you to confirm that what you see in the source code is the same as what is in the DLL.

MarkCiliaVincenti avatar Feb 02 '24 18:02 MarkCiliaVincenti

Do you want this PR closed?

MarkCiliaVincenti avatar Apr 21 '24 14:04 MarkCiliaVincenti