Treecapitator
Treecapitator copied to clipboard
Fix HarvestDropsEvent being bypassed when stackDrops is true
- Fixes #32
Should be safe to merge to 1.8 as well.
Hi squeek, I tried to add the code you suggested (in my private modpack) and didn't work. Skill level of my axe still increases itself of 1 point, even if I cut a tree using TreeCapitator...
I never actually tested it with ITT. I'll try to do that later today.
Thank you. Could I ask you to keep me updated on your tests, please?
Ah, @AlexPlus117, just realized that this isn't a fix for the ITT problem. Here's what I posted when I linked to this issue from the ITT issue:
I've submitted a pull request that fixes a similar incompatibility and it's gotten no action.
This PR fixes https://github.com/squeek502/VeganOption/issues/30, not the onBlockStartBreak
issue that ITT needs. That will require a different fix.
Ah, ok. If I don't annoy you, can you give me, privately, the fix for ITT problem, please?
I'd have to look into it a bit more. Once I do, I'll add the fix to this PR.
Ok, thank you.
@AlexPlus117, sorry, but the fix that ITT needs is actually somewhat complicated--simply due to the fact that Treecapitator reimplements so much harvesting functionality that it's hard to figure out where onBlockStartBreak
should be called and then detect and fix any unintended effects--and I'm not willing to invest the time necessary to figure everything out. You'll have to find someone more familiar with Treecapitator and who is willing to put in the effort to fix that.