Treecapitator icon indicating copy to clipboard operation
Treecapitator copied to clipboard

Fix HarvestDropsEvent being bypassed when stackDrops is true

Open squeek502 opened this issue 9 years ago • 8 comments

  • Fixes #32

Should be safe to merge to 1.8 as well.

squeek502 avatar Aug 28 '15 07:08 squeek502

Hi squeek, I tried to add the code you suggested (in my private modpack) and didn't work. Skill level of my axe still increases itself of 1 point, even if I cut a tree using TreeCapitator...

AlexPlus117 avatar Dec 23 '15 19:12 AlexPlus117

I never actually tested it with ITT. I'll try to do that later today.

squeek502 avatar Dec 23 '15 19:12 squeek502

Thank you. Could I ask you to keep me updated on your tests, please?

AlexPlus117 avatar Dec 23 '15 19:12 AlexPlus117

Ah, @AlexPlus117, just realized that this isn't a fix for the ITT problem. Here's what I posted when I linked to this issue from the ITT issue:

I've submitted a pull request that fixes a similar incompatibility and it's gotten no action.

This PR fixes https://github.com/squeek502/VeganOption/issues/30, not the onBlockStartBreak issue that ITT needs. That will require a different fix.

squeek502 avatar Dec 23 '15 20:12 squeek502

Ah, ok. If I don't annoy you, can you give me, privately, the fix for ITT problem, please?

AlexPlus117 avatar Dec 24 '15 10:12 AlexPlus117

I'd have to look into it a bit more. Once I do, I'll add the fix to this PR.

squeek502 avatar Dec 24 '15 19:12 squeek502

Ok, thank you.

AlexPlus117 avatar Dec 24 '15 19:12 AlexPlus117

@AlexPlus117, sorry, but the fix that ITT needs is actually somewhat complicated--simply due to the fact that Treecapitator reimplements so much harvesting functionality that it's hard to figure out where onBlockStartBreak should be called and then detect and fix any unintended effects--and I'm not willing to invest the time necessary to figure everything out. You'll have to find someone more familiar with Treecapitator and who is willing to put in the effort to fix that.

squeek502 avatar Dec 27 '15 01:12 squeek502