python-mingus icon indicating copy to clipboard operation
python-mingus copied to clipboard

Removing velocity and channel attributes of Note class

Open PettaBoy opened this issue 4 years ago • 3 comments

This has been mentioned by several people also.

PettaBoy avatar Sep 05 '21 12:09 PettaBoy

Hi @PettaBoy, what exactly is the purpose of this change? The velocity and channel attributes are still referenced by other methods. Also, they are used in several places across the codebase, so there's more to removing them than just removing these two lines.

edudobay avatar Sep 07 '21 22:09 edudobay

I understand that @edudobay, but this is becoming a big problem in the development of one of my applications. If I leave the code alone, then I might not be able to change the program of the keyboard unless I am at channel 1. This will severely affect the chances of me developing a multi channel application in the future. Also, the keyboard won't be able to play the MIDI percussion instruments with the current code. My bad, though. Should have done more research before putting this out. Here's the Github repo of the app if you want to check it out: https://github.com/PettaBoy/VirtualMusicKeyboard

PettaBoy avatar Sep 09 '21 06:09 PettaBoy

Thought I'll reference #21 and #22 to this as well. Unfortunately it got closed by the author.

PettaBoy avatar Sep 10 '21 12:09 PettaBoy