python-mingus icon indicating copy to clipboard operation
python-mingus copied to clipboard

documentation

Open dpawson opened this issue 10 years ago • 3 comments

html documentation has

interval.measure("C", "D") 2 interval.measure("D", "C") 10

I think it should be 'intervals' (plural)

HTH

dpawson avatar Sep 04 '15 16:09 dpawson

Running Python 3. Input

|A C# E |Bb D F |B D# F# |C E G |C# E# G#

Transpose C to F

Traceback (most recent call last): File "/files/python/transposer/transposer/transposer.py", line 170, in main() File "/files/python/transposer/transposer/transposer.py", line 164, in main result = transpose_file(file_name, from_key, to_key) File "/files/python/transposer/transposer/transposer.py", line 82, in transpose_file result += transpose_line(line, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 108, in transpose_line return recursive_line_transpose(source_line, source_chords, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 119, in recursive_line_transpose recursive_line_transpose(source_line[after_chord_index:], source_chords, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 118, in recursive_line_transpose transpose(source_chord, direction, to_key) +
File "/files/python/transposer/transposer/transposer.py", line 128, in transpose source_index = get_index_from_key(source_chord) File "/files/python/transposer/transposer/transposer.py", line 50, in get_index_from_key raise Exception("Invalid key: %s" % source_key) Exception: Invalid key: E# /docs/2016/piano/billHiltondpawson12:41> /docs/2016/piano/billHiltondpawson12:41>transpose.sh C F chords.txt Traceback (most recent call last): File "/files/python/transposer/transposer/transposer.py", line 170, in main() File "/files/python/transposer/transposer/transposer.py", line 164, in main result = transpose_file(file_name, from_key, to_key) File "/files/python/transposer/transposer/transposer.py", line 82, in transpose_file result += transpose_line(line, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 108, in transpose_line return recursive_line_transpose(source_line, source_chords, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 119, in recursive_line_transpose recursive_line_transpose(source_line[after_chord_index:], source_chords, direction, to_key) File "/files/python/transposer/transposer/transposer.py", line 118, in recursive_line_transpose transpose(source_chord, direction, to_key) +
File "/files/python/transposer/transposer/transposer.py", line 128, in transpose source_index = get_index_from_key(source_chord) File "/files/python/transposer/transposer/transposer.py", line 50, in get_index_from_key raise Exception("Invalid key: %s" % source_key) Exception: Invalid key: E#

dpawson avatar Jul 21 '16 11:07 dpawson

E# is F... perhaps it is restricting it to the note without the sharp.

Doomfist0 avatar Mar 07 '17 20:03 Doomfist0

Yes, that makes sense, though it seems rather harsh to bomb out with the obvious? Tks.

Yes, Seems no testing is done on either notes or input key.

dpawson avatar Mar 08 '17 07:03 dpawson