iThenticate icon indicating copy to clipboard operation
iThenticate copied to clipboard

Php 8 and pull requests

Open joelfan opened this issue 3 years ago • 3 comments

Dear Sam,

I understand that bsobbe/iThenticate requires php7 but excludes php8. It seems to me that the issue is due to the use of phpxmlrpc 4.0. In fact, compose.json states "phpxmlrpc/phpxmlrpc": "4.0". I know that phpxmlrpc/phpxmlrpc is now updated to 4.6.1. As far as I know, php8 is not compatible with some php7 instructions (for example "each" operator), hence bsobbe/iThenticate is not compatible with php8. Have you got plans to port it to php8?

Secondarily, it would be super if bsobbe/iThenticate library could also include iThenticate user management. That means define a new user if not existing and share a folder to other users when necessary. We would like to know your view about it.

Thx a lot for you help.

joelfan avatar Mar 11 '22 10:03 joelfan

@joelfan Sorry for the late response. I have no plans for this repository anytime soon, but it would be nice to have that support. you could fork and do a PR so everybody else could benefit from this support as well :)

bsobbe avatar Mar 21 '22 15:03 bsobbe

Ok. I will fork and then come back.

joelfan avatar Mar 22 '22 12:03 joelfan

Dear Sam, I've done the fork and the pull. I also tested it. Please take a look and tell me your view.

joelfan avatar Mar 22 '22 12:03 joelfan