Braden Shepherdson comments

Results 106 comments of


                                            Braden Shepherdson

[perf] Add metric for `lib.computed/weak-map` size; speculative fixes

* **#66404** 👈 (View in Graphite) * `master` This stack of pull requests is managed by Graphite. Learn more about stacking.

[perf] Add metric for `lib.computed/weak-map` size; speculative fixes

> To confirm my understanding, if it was weak map was growing too large and the speculative fix of using the MPs internal cache instead of the weak map works,...

[perf] Add metric for `lib.computed/weak-map` size; speculative fixes

Not with all these test failures; there's something broken in the caching. I haven't had any leeway to debug; more critical issues have been preempting me all week.

Deselecting fields on GUI questions will bust questions for users with row level security

Does it work to deselect a different field, one that isn't a primary key?

Deselecting fields on GUI questions will bust questions for users with row level security

### Breakdown On taking a deeper look here, there's a few moving parts. Let me try to break down what's happening here: - The admin user creates a question we...

Cannot Select Columns in the Query Builder After Joining a Native SQL Model

Possibly trouble with `lib.field.resolution` not being able to select certain columns? Hard to know at a glance.

Columns Renamed in Model Metadata aren't Propagated to Downstream Questions in Some Cases

This sounds like we're failing to match up the overridden model metadata with the inner query's columns, when they're on the RHS of a join. I'll follow the repro and...

QP confuses column for table name on very large table names with offset

This query is broken. The error message is admittedly bad, but that's coming from BigQuery. The problem is that the original query tries to `offset([basic field], -1)` but the first...

QP confuses column for table name on very large table names with offset

Huh, I'm curious why that worked for me but is breaking for you, since it seems like we did very similar queries. @yadutaf can you include the SQL for that...

QP confuses column for table name on very large table names with offset

Great, thanks. I think I figured out the reason for our different repros - I was running master, reproduced the original issue (with the broken `offset`), and then forgot to...