oauth2-server-php icon indicating copy to clipboard operation
oauth2-server-php copied to clipboard

Add support for OpenID Connect PKCE

Open darthsteven opened this issue 7 years ago • 8 comments

Very much a WIP and not finished, just getting something out there and started.

Stay tuned!

Relates to #752

I will note that if some wants PCKE and can enforce PHP>7.0 then https://oauth2.thephpleague.com/ might be a better way to go.

darthsteven avatar Nov 20 '18 07:11 darthsteven

Note that I'm using this with a Drupal oauth2 server module: https://www.drupal.org/project/oauth2_server/issues/3015065#comment-12863529 which basically swaps out the storage class.

I've not updated the built in storage classes, hence all the test failures.

darthsteven avatar Nov 20 '18 13:11 darthsteven

I was very excited to see that you two had been working on PKCE. I need to implement PKCE and would prefer to keep this library. Is this still a work in progress of can I merge the six files and apdate the database to get it running?

keithgordon2 avatar Jun 16 '20 20:06 keithgordon2

@keithgordon2 yeah, it should work fine at the moment. It's still technically a WIP in terms of getting the storage classes updated and tests passing, but if you are swapping out the storage class anyway, then this code works fine as such :)

darthsteven avatar Jun 17 '20 06:06 darthsteven

@darthsteven any update to this? I need to implement PKCE for mobile authorization, and seems this library doesn't support this atm..

ezralazuardy avatar Aug 15 '20 15:08 ezralazuardy

Ezra,

I got the PKCE to work with darthsteven's changes and a couple quick database and database code changes.

keithgordon2 avatar Aug 16 '20 18:08 keithgordon2

@ezralazuardy if you want some working PKCE code and are free to use any library then take a look at https://oauth2.thephpleague.com/ which has PKCE support already.

darthsteven avatar Aug 20 '20 14:08 darthsteven

@darthsteven yes, i've try it couple days ago and work perfectly for my project. thanks for the respond though..

ezralazuardy avatar Aug 26 '20 15:08 ezralazuardy

Thanks @darthsteven - I have tried to finish this in a new PR, as I would like to have this support in this lib: https://github.com/bshaffer/oauth2-server-php/pull/1045 I will welcome if you check it :)

thaarok avatar Feb 26 '23 12:02 thaarok