oauth2-demo-php icon indicating copy to clipboard operation
oauth2-demo-php copied to clipboard

Published 20 hours ago • verified publisher icon bshaffer

Curl Resource Request Test

Open marovelo opened this issue 11 years ago • 3 comments

This Pull request is related to https://github.com/bshaffer/oauth2-server-php/issues/254

marovelo avatar Nov 08 '13 09:11 marovelo

Can you please explain to me the reason for this pull request?

The "required scope" should be built into the resource action itself, ie hard coded somewhere, and not part of the request, as is the case in this PR.

bshaffer avatar Nov 08 '13 16:11 bshaffer

This pull request is related to bshaffer/oauth2-server-php#254 Just to show my problem in code that I describe in this issue. However, as I said in the issue, the Test in this pull request doesn't fail.

marovelo avatar Nov 11 '13 08:11 marovelo

Thank you for this. I am closing this since a test suite for this demo app will require a more standard method of testing (using behat/mink, etc).

However, I think the tests you've written would be a great addition to your own app imlementation

bshaffer avatar Nov 11 '13 14:11 bshaffer