oauth2-demo-php icon indicating copy to clipboard operation
oauth2-demo-php copied to clipboard

Published 20 hours ago • verified publisher icon bshaffer

Make Code Easier to Follow

Open bshaffer opened this issue 11 years ago • 3 comments

Lots of people get pointed here, but how is it to understand what's going on unless you have an understanding of silex?

The ansewr is... very hard!!. This is suppsed to be simple, so give these people a break!

bshaffer avatar May 10 '13 21:05 bshaffer

  • Change LockdIn to OAuth2_Server
  • Change Demo to OAuth2_Client
  • refactor index.php into something more intuitive
  • refactor Controller Provider into something more intuitive

bshaffer avatar May 10 '13 21:05 bshaffer

All of these have been completed in 6d8b8c0

bshaffer avatar May 11 '13 01:05 bshaffer

Some new ideas:

  • Rename Client.php and Server.php to Routing.php, as all these do is declare the routes for the controller classes
  • Get rid of addRoutes on controller classes, and have this done by the routing classes
  • Find a home in Shared for the configuration logic currently in index.php
  • Find a better home for where the OAuth2 server is set up... currently in Server.php

bshaffer avatar May 11 '13 01:05 bshaffer