Poul-Henning Kamp
Poul-Henning Kamp
I'm OK with this, as long as this iterator API is only for use by the CLI thread, and this should be documented in the code with an ``ASSERT_CLI()`` because...
The reason I dont want them on by default is that the back-trace will be piped into people's automation.
», VEXTs need to be present in the manager for opening privileged ports etc.« This is simply not true. VEXT's get a chance to bite before privileges are dropped right...
First: Why?! What is the use-case for CONNECT in a server-side proxy as opposed to a client-side proxy ? Second: This SHALL be disabled by default so a Varnish instance...
Originally we decided to just close on abusive input, to improve DoS resistance. That still sounds sensible to me, but if there is a need for more civilized behaviour, we...
We bugwashed it, and my previous comment stands. If we want to modulate behaviour, it has to be a featureflag, we cannot ask VCL since we cannot represent the request...
I'm -1 on this one. It doesn't seem hard to do it properly (see todays IRC log)
Needs more work. I dont like that the strings become unquoted. Also: strlen() on constant strings is free with all compilers in recent memory.
First apologies for confusing everybody with a sign-error on the underscore There is no reason to retain this check because all relevant platforms today have pthread_setname_np() and if somebody wants...
This looks like a good compromise until we move the acceptor code. Ok with me.