bsb-native icon indicating copy to clipboard operation
bsb-native copied to clipboard
verified publisher icon bsansouci

Generated binary name inconsistent between macos & windows (macos doesn't have .exe suffix)

Open jaredly opened this issue 7 years ago • 3 comments

It would make scripts a lot simpler if all platforms generated the same binary name.

jaredly avatar Aug 09 '18 04:08 jaredly

Is the fix as simple as changing https://github.com/bsansouci/bsb-native/blob/95055bec3e0acb728902babc4709c26fa9f0831d/jscomp/bsb/bsb_ninja_native.ml#L474 to just be .exe all the time?

jaredly avatar Aug 09 '18 05:08 jaredly

Yeah should be sufficient

bsansouci avatar Aug 09 '18 08:08 bsansouci

will break lots of little existing scripts so lets do it as part of a bigger upgrade if possible

Schmavery avatar Aug 11 '18 21:08 Schmavery