bryzgaloff
fix for boolean type conversion
Thanks for the review! I fixed most of review comments.
Regarding the first one about the method of passing arguments to clickhouse_driver.Client - currently there's 23 arguments, most of them are optionals. So, minimal boilerplate version should use something like Pydantic. And it looks like a little overkill to me. What do you think?
Regarding the first one about the method of passing arguments to
clickhouse_driver.Client- currently there's 23 arguments, most of them are optionals. So, minimal boilerplate version should use something like Pydantic. And it looks like a little overkill to me. What do you think?
Hi @akurdyukov, yes, definitely using an external library is an overkill here. I suggest to hardcode all the arguments: clickhouse-driver is not expected to change them often, so we may accept new PRs once the arguments change in the underlying library.
