Pete F
Pete F
>**Note** >This is an automatically-generated comment. Feel free to edit the content, but please don't edit this 'note' block. # Intro to report Copying the intro here to aid discoverability...
> But to confirm, I don't have many concerns around the visual regression coverage of _this_ PR, as I made all the refactors to the stories after verifying I was...
> 🤔 Is the `shouldPadWrappableRows` function perhaps similar to [this one](https://github.com/guardian/dotcom-rendering/blob/622bdea81332c99a5fd07cf9702a256095b44067/dotcom-rendering/src/web/components/FixedMediumFastXI.tsx#L18)? fwiw I've got an idea for simplifying at least some of the divider functionality that I discussed with @OllysCoding...
>**Note** >This is an automatically-generated comment. Feel free to edit the content, but please don't edit this 'note' block. # Intro to report Copying the intro here to aid discoverability...
> do we have any update on what we are doing with video carousels? This should be taken into account when building that. > It would be good to know...
> Could you give a little context as to when this was introduced in the PR? > > I’ve found [96d063a#diff-05d6bf9d6843889ccfffced1ad06ec55b377250ab96e2880578dbd8665239b9aR630-R631](https://github.com/guardian/dotcom-rendering/commit/96d063ad1f1372b06da90a8bf6d75bc7a9bd2388#diff-05d6bf9d6843889ccfffced1ad06ec55b377250ab96e2880578dbd8665239b9aR630-R631) where it seems to have been introduced. Yes, will...
closing; see updated PR description above.
> I've added a `CSROnwardsCollectionResponse` as it will never have trails Will DCR use the other properties of the `CSROnwardsCollectionResponse` (i.e. `heading`, `format`, etc.) in the current implementation?
Thanks for your response! I agree that the `requirements.txt` approach feels more appropriate here. I've raised a quick PR, but not sure if this fits with the way you'd want...
this is in the `In Progress` column in the Rota board -- is it still in progress? If not, does it need to be picked up again? cc. @ioannakok @OllysCoding