Bryan Van de Ven
Bryan Van de Ven
@drammock yah that could use some tweaking but it's already much better, I will probably put this with some tweaks in the next Bokeh release as a stopgap, just because...
@choldgraf This looks nice, a couple of comments: * I think the specificity of distinct messages for "outdated" vs "unreleased" is a nice-to-have, but a combined single message will do...
> The version (in switcher.json) is always called "dev" or "development" I might be misunderstanding of some aspect of how the switcher works. I don't really understand what this is...
> On MetPy we haven't yet switched to the built-in version selector (we're on an old one). We check against DOCUMENTATION_OPTIONS.VERSION and point to latest (which is a symlink) if...
> In version.json one of the entries can have a preferred: true key/val This would work, but it also seems somewhat more difficult to maintain. Updating now requires finding the...
@choldgraf I personally think that would be a good (forward-looking) change but I'm also only thinking about the benefits, not any costs :) Obviously that's something for the PST team...
> Mark your "preferred" release with "preferred": "true". Add a description to any you wanted a custom description for. Depending on your naming, you might have to update the entry...
> change 1 line of the JSON file each time there's a release The issue for me is that rather than simply adding or replacing a line (even a block),...
@choldgraf I do think we have some terminology differences. But I was able to distill the important difference to this I think: The theme seems to assume that the "latest"...
@choldgraf if we have this: ``` { "preferred": "4.3.7", "versions": [], } ``` then assuming: * Any page (regardless of URL location) with `DOCUMENTATION_OPTIONS.VERSION == "4.3.7"` gets no banner, and...