GoMap icon indicating copy to clipboard operation
GoMap copied to clipboard

User is able to save untagged way

Open danieldegroot2 opened this issue 11 months ago • 6 comments

User was able to save temporary guideline / placeholder line at https://www.openstreetmap.org/edit?way=1384443332#map=20/51.8626520/4.4748570 ( is: https://www.openstreetmap.org/way/1384443332/history )

Prohibit users from saving empty / tagless objects. They should go back to select a preset / tag (key+value) first before uploading. (see also iD / JOSM returns 'error' warning on saving changeset.)

Go Map!! 4.3.2 (iPhone); ask changeset author for details if needed

danieldegroot2 avatar May 08 '25 18:05 danieldegroot2

I just tested iD and it allowed me to upload an object with no tags: https://www.openstreetmap.org/changeset/166224783

bryceco avatar May 13 '25 21:05 bryceco

But… it will also notify users during the save dialog. The "Line has no tags" error selects the line when clicked.

Image

Not saying that I consider this something for GoMap, just that this is how iD "prevents" the error.


PS: https://ideditor.netlify.app/#disable_features=boundaries&map=20.63/52.47409/13.44565&background=Berlin-2024&locale=en has the red "live" button at the bottom that change to the dev server which can be used for testing uploads (but requires a separate user account). Image

tordans avatar May 14 '25 04:05 tordans

I agree that iD provides warnings, but it doesn't block it outright.

iD has a great set of validations, and if we ever implement something similar then this is something that should be included.

bryceco avatar May 14 '25 05:05 bryceco

iD removes existing objects' tags, but it still allows uploading key with empty value "*"=""). ( https://github.com/openstreetmap/iD/issues/1894 )

I suppose Go Map user must have added such key with empty value.


iD does not allow uploading object without any keys/tags, however. See greyed out Upload button in tordans' example (with block icon cursor and hover text 'Resolve issues first. Open issues: 1.'.

danieldegroot2 avatar May 15 '25 15:05 danieldegroot2

I don't know why my session was different than @tordans but I wasn't blocked from creating an untagged way. You can look at the OSC file attached to my changeset above to verify it. But I just tried it again and it was indeed blocked 🤷‍♂️.

<osmChange version="0.6" generator="openstreetmap-cgimap 2.0.1 (2270294 spike-07.openstreetmap.org)" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
<create>
<node id="12834805526" visible="true" version="1" changeset="166224783" timestamp="2025-05-13T21:25:52Z" user="bryceco" uid="624323" lat="47.6794580" lon="-122.2129361"/>
</create>
<create>
<node id="12834805527" visible="true" version="1" changeset="166224783" timestamp="2025-05-13T21:25:52Z" user="bryceco" uid="624323" lat="47.6794089" lon="-122.2128842"/>
</create>
<create>
<way id="1386312144" visible="true" version="1" changeset="166224783" timestamp="2025-05-13T21:25:52Z" user="bryceco" uid="624323">
<nd ref="12834805526"/>
<nd ref="12834805527"/>
</way>
</create>
</osmChange>

bryceco avatar May 15 '25 20:05 bryceco

See also https://github.com/openstreetmap/iD/issues/9553

danieldegroot2 avatar May 15 '25 22:05 danieldegroot2